From rpgoldman at sift.net Tue May 2 18:30:29 2023 From: rpgoldman at sift.net (Robert Goldman) Date: Tue, 02 May 2023 13:30:29 -0500 Subject: Review MR 27, please Message-ID: If anyone is still on this mailing list, would you please review this MR and either make requests for fixing it, or merge it? Note that the regression tests are broken on the master branch. One of the reasons I would like to get this MR merged is that I would very much like to finish fixing the regression tests so that we have a secure foundation for any further bug fixes. Thanks, R From mark at dymek.me Tue May 2 18:41:52 2023 From: mark at dymek.me (Mark Dymek) Date: Tue, 02 May 2023 14:41:52 -0400 Subject: Review MR 27, please In-Reply-To: References: Message-ID: <36ac79a2-e298-44c2-93ca-6ba750698e3d@app.fastmail.com> i didn’t get any attachment in your email so not sure what you want checked. On Tue, May 2, 2023, at 2:30 PM, Robert Goldman wrote: > If anyone is still on this mailing list, would you please review this MR and either make requests for fixing it, or merge it? > > Note that the regression tests are broken on the master branch. One of the reasons I would like to get this MR merged is that I would very much like to finish fixing the regression tests so that we have a secure foundation for any further bug fixes. > > Thanks, > R > > -------------- next part -------------- An HTML attachment was scrubbed... URL: From rpgoldman at sift.net Tue May 2 18:45:15 2023 From: rpgoldman at sift.net (Robert Goldman) Date: Tue, 02 May 2023 13:45:15 -0500 Subject: Review MR 27, please In-Reply-To: <36ac79a2-e298-44c2-93ca-6ba750698e3d@app.fastmail.com> References: <36ac79a2-e298-44c2-93ca-6ba750698e3d@app.fastmail.com> Message-ID: <39716993-9921-4A51-A4AC-B12BE7D3DFA7@sift.net> Sorry, I was referring to MR 27 on the Alexandria GitLab: https://gitlab.common-lisp.net/alexandria/alexandria/-/merge_requests/27 I apologize for not being clear. On 2 May 2023, at 13:41, Mark Dymek wrote: > i didn’t get any attachment in your email so not sure what you want > checked. > > On Tue, May 2, 2023, at 2:30 PM, Robert Goldman wrote: >> If anyone is still on this mailing list, would you please review this >> MR and either make requests for fixing it, or merge it? >> >> Note that the regression tests are broken on the master branch. One >> of the reasons I would like to get this MR merged is that I would >> very much like to finish fixing the regression tests so that we have >> a secure foundation for any further bug fixes. >> >> Thanks, >> R >> >> -------------- next part -------------- An HTML attachment was scrubbed... URL: From mark at dymek.me Tue May 2 18:49:24 2023 From: mark at dymek.me (Mark Dymek) Date: Tue, 02 May 2023 14:49:24 -0400 Subject: Review MR 27, please In-Reply-To: <39716993-9921-4A51-A4AC-B12BE7D3DFA7@sift.net> References: <36ac79a2-e298-44c2-93ca-6ba750698e3d@app.fastmail.com> <39716993-9921-4A51-A4AC-B12BE7D3DFA7@sift.net> Message-ID: <6af873f2-7c7f-49f7-9b1a-8d643f27d491@app.fastmail.com> don’t ever remember joining this mailing list or why i would want to lol. can i be unsubscribed? On Tue, May 2, 2023, at 2:45 PM, Robert Goldman wrote: > Sorry, I was referring to MR 27 on the Alexandria GitLab: https://gitlab.common-lisp.net/alexandria/alexandria/-/merge_requests/27 > > I apologize for not being clear. > > On 2 May 2023, at 13:41, Mark Dymek wrote: > >> i didn’t get any attachment in your email so not sure what you want checked. >> >> On Tue, May 2, 2023, at 2:30 PM, Robert Goldman wrote: >>> If anyone is still on this mailing list, would you please review this MR and either make requests for fixing it, or merge it? >>> >>> Note that the regression tests are broken on the master branch. One of the reasons I would like to get this MR merged is that I would very much like to finish fixing the regression tests so that we have a secure foundation for any further bug fixes. >>> >>> Thanks, >>> R >>> >>> >> > -------------- next part -------------- An HTML attachment was scrubbed... URL: From philipp at marek.priv.at Tue May 2 18:58:56 2023 From: philipp at marek.priv.at (Philipp Marek) Date: Tue, 02 May 2023 18:58:56 +0000 Subject: Review MR 27, please In-Reply-To: References: Message-ID: <52C737EF-9736-4DD5-BEBA-B4B87DE3F569@marek.priv.at> I'll look at it tomorrow.