[alexandria-devel] [PATCH] add lastcons

Nikodemus Siivola nikodemus at random-state.net
Sun Oct 30 12:10:57 UTC 2011


On 18 May 2010 23:29, Mathieu Lemoine <mathieu.lemoine at gmail.com> wrote:

(Again, sorry about the tardy reply!)

> I made a little addition to the library. The lastcons function... It
> is very simple and I found myself thinking "that's something that
> ought to be in alexandria"...

Thank you, but ... this already exists in Alexandria, under the name LASTCAR.

> Not knowing the exact procedure to commit to the repo (and "git push"
> give me a "fatal: The remote end hung up unexpectedly" which is to be
> expected, I guess...), I send you the patch.

For future reference, my preference is:

1. When sending in patches that add in functions, include the
docstring of the function in the message body. Makes it easier to see
what it is about.

2. Use "git format-patch -1" (as you did) to produce the patch.

3. Remember to include test-cases.

Cheers,

 -- nikodemus




More information about the alexandria-devel mailing list